Bug 177707 - Add a layout test test that exercises setData and getData for non-normalized types
Summary: Add a layout test test that exercises setData and getData for non-normalized ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-30 13:18 PDT by Wenson Hsieh
Modified: 2017-09-30 22:00 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.40 KB, patch)
2017-09-30 13:27 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (4.83 KB, patch)
2017-09-30 18:26 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-09-30 13:18:17 PDT 
We have test coverage for getData and setData with non-normalized types on the internal bots where custom pasteboard data is enabled by default, but this is not the case in EWS. Let's add a test covering this case so that we'll catch bugs earlier on in EWS.
Comment 1 Wenson Hsieh 2017-09-30 13:27:18 PDT 
Created attachment 322298 [details]
Patch
Comment 2 Wenson Hsieh 2017-09-30 16:06:51 PDT 
Comment on attachment 322298 [details]
Patch

Thanks Darin!
Comment 3 WebKit Commit Bot 2017-09-30 16:33:13 PDT 
Comment on attachment 322298 [details]
Patch

Clearing flags on attachment: 322298

Committed r222685: <http://trac.webkit.org/changeset/222685>
Comment 4 WebKit Commit Bot 2017-09-30 16:33:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-09-30 16:33:48 PDT 
<rdar://problem/34757717>
Comment 6 Ryosuke Niwa 2017-09-30 16:55:51 PDT 
We should probably test whitespce stripping as well.
Comment 7 Wenson Hsieh 2017-09-30 17:44:09 PDT 
(In reply to Ryosuke Niwa from comment #6)
> We should probably test whitespce stripping as well.

Sure. Reopening to tweak the test.
Comment 8 Wenson Hsieh 2017-09-30 18:26:10 PDT 
Created attachment 322306 [details]
Patch
Comment 9 WebKit Commit Bot 2017-09-30 22:00:06 PDT 
Comment on attachment 322306 [details]
Patch

Clearing flags on attachment: 322306

Committed r222687: <http://trac.webkit.org/changeset/222687>
Comment 10 WebKit Commit Bot 2017-09-30 22:00:08 PDT 
All reviewed patches have been landed.  Closing bug.