Bug 177706 - Add makeWeakPtr for easier WeakPtr construction
Summary: Add makeWeakPtr for easier WeakPtr construction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-30 01:48 PDT by Antti Koivisto
Modified: 2017-09-30 13:11 PDT (History)
7 users (show)

See Also:


Attachments
patch (8.08 KB, patch)
2017-09-30 02:07 PDT, Antti Koivisto
sam: review+
Details | Formatted Diff | Diff
patch (7.73 KB, patch)
2017-09-30 04:42 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-09-30 01:48:53 PDT
Better WeakPtr construction.
Comment 1 Antti Koivisto 2017-09-30 02:07:58 PDT
Created attachment 322291 [details]
patch
Comment 2 Sam Weinig 2017-09-30 02:16:39 PDT
Comment on attachment 322291 [details]
patch

r=me. I would separate out the operator bool change, since that will probably require some API test changes.
Comment 3 Antti Koivisto 2017-09-30 04:42:58 PDT
Created attachment 322294 [details]
patch
Comment 4 WebKit Commit Bot 2017-09-30 06:44:07 PDT
Comment on attachment 322294 [details]
patch

Clearing flags on attachment: 322294

Committed r222682: <http://trac.webkit.org/changeset/222682>
Comment 5 WebKit Commit Bot 2017-09-30 06:44:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-30 06:45:30 PDT
<rdar://problem/34755419>
Comment 7 Ryosuke Niwa 2017-09-30 13:11:33 PDT
We can also add variants of makeWeakPtr which takes RefPtr & Ref!