Bug 177703 - [JSC] Introduce import.meta
Summary: [JSC] Introduce import.meta
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-29 23:21 PDT by Yusuke Suzuki
Modified: 2017-10-04 22:15 PDT (History)
7 users (show)

See Also:

Attachments
Patch (24.03 KB, patch)
2017-09-30 01:22 PDT, Yusuke Suzuki 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-09-29 23:21:36 PDT 
import.meta becomes stage 3.
Comment 1 Yusuke Suzuki 2017-09-30 01:22:11 PDT 
Created attachment 322287 [details]
Patch
Comment 2 Yusuke Suzuki 2017-10-04 20:12:09 PDT 
Ping?
Comment 3 Filip Pizlo 2017-10-04 20:15:29 PDT 
Comment on attachment 322287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322287&action=review

> Source/JavaScriptCore/parser/Parser.cpp:431
> +            // They are `import("...")` call or `import.meta` meta property cases.

It’s still “this is”. This is one thing, which we choose from two things. Therefore, singular.
Comment 4 Yusuke Suzuki 2017-10-04 20:53:46 PDT 
Comment on attachment 322287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322287&action=review

>> Source/JavaScriptCore/parser/Parser.cpp:431
>> +            // They are `import("...")` call or `import.meta` meta property cases.
> 
> It’s still “this is”. This is one thing, which we choose from two things. Therefore, singular.

Oh! Thanks, fixed.
Comment 5 Yusuke Suzuki 2017-10-04 20:57:49 PDT 
Committed r222895: <http://trac.webkit.org/changeset/222895>
Comment 6 Radar WebKit Bug Importer 2017-10-04 20:58:15 PDT 
<rdar://problem/34827357>
Comment 7 Saam Barati 2017-10-04 22:15:52 PDT 
Comment on attachment 322287 [details]
Patch

LGTM too