Bug 177697 - Expose more WKPreferences SPI to match C SPI
Summary: Expose more WKPreferences SPI to match C SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-29 18:24 PDT by Alex Christensen
Modified: 2017-10-02 10:36 PDT (History)
3 users (show)

See Also:

Attachments
Patch (14.50 KB, patch)
2017-09-29 18:25 PDT, Alex Christensen 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-09-29 18:24:45 PDT 
Expose more WKPreferences SPI to match C SPI
Comment 1 Alex Christensen 2017-09-29 18:25:20 PDT 
Created attachment 322261 [details]
Patch
Comment 2 Alex Christensen 2017-10-02 09:50:24 PDT 
http://trac.webkit.org/r222711
Comment 3 Radar WebKit Bug Importer 2017-10-02 09:51:30 PDT 
<rdar://problem/34768813>
Comment 4 mitz 2017-10-02 09:59:09 PDT 
Comment on attachment 322261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322261&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:669
> +- (BOOL)_javaEnabledForLocalFiles
> +{
> +    return _preferences->pluginsEnabled();
> +}

Is this correct? I’d expect the underlying function to be something about Java for local files.
Comment 5 Alex Christensen 2017-10-02 10:02:41 PDT 
Not only are you correct, but also my SPI version of _plugInsEnabled is not needed because we have public API for that.  Will fix.
Comment 6 Alex Christensen 2017-10-02 10:13:34 PDT 
http://trac.webkit.org/r222715
Comment 7 Alex Christensen 2017-10-02 10:36:29 PDT 
https://trac.webkit.org/changeset/222718/webkit