Bug 177689 – Remove ENABLE_CSS_REGIONS

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Michael Catanzaro]

Remove ENABLE_CSS_REGIONS.

Also, for GTK, deprecate webkit_dom_element_get_webkit_region_overset. This is no problem because the API was added automatically and it's likely that zero applications are using it.

[Michael Catanzaro]

Created attachment 322253 [details]
Patch

[Michael Catanzaro]

(In reply to Michael Catanzaro from comment #0)
> Remove ENABLE_CSS_REGIONS.
> 
> Also, for GTK, deprecate webkit_dom_element_get_webkit_region_overset. This
> is no problem because the API was added automatically and it's likely that
> zero applications are using it.

Also, the API has never done anything, since GTK has never enabled ENABLE_CSS_REGIONS. I forgot how much fun autogenerated API was!

[Michael Catanzaro]

Hmmm I didn't notice the GObject property, we need to decide how to handle that.

[Michael Catanzaro]

Created attachment 322318 [details]
Patch

[Darin Adler]

Comment on attachment 322318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322318&action=review

> Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.cpp:325
> +    g_warning("%s: CSS Regions support has been removed, this function does nothing.", __func__);

This says "does nothing".

> Source/WebKit/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp:249
> +        g_warning("%s: CSS Regions support has been removed, the webkit-region-overset property no longer works.", __func__);

This says "no longer works". I think I like "does nothing" better.

[Michael Catanzaro]

The problem is a property never does anything, it just exists, so the "does nothing" text doesn't work as well there.

[WebKit Commit Bot]

Comment on attachment 322318 [details]
Patch

Clearing flags on attachment: 322318

Committed r222704: <http://trac.webkit.org/changeset/222704>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34765572>