WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 177679
[High Sierra Release WK2] LayoutTest http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=177679
Summary
[High Sierra Release WK2] LayoutTest http/tests/loading/resourceLoadStatistic...
Ryan Haddad
Reported
2017-09-29 13:24:09 PDT
LayoutTest http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html is a flaky failure
https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r222634%20(46)/results.html
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Floading%2FresourceLoadStatistics%2Fpartitioned-cookies-with-and-without-user-interaction.html
--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction-actual.txt @@ -4,7 +4,7 @@ main frame - didChangeLocationWithinPageForFrame main frame - willPerformClientRedirectToURL:
http://localhost:8000/loading/resourceLoadStatistics/resources/set-cookie.php?name=firstPartyCookie&value=value#http://127.0.0.1:8000/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html#step2
main frame - didFinishDocumentLoadForFrame -main frame - didFinishLoadForFrame +main frame - didFailLoadWithError main frame - didStartProvisionalLoadForFrame main frame - didCancelClientRedirectForFrame main frame - didCommitLoadForFrame
Attachments
Patch
(4.77 KB, patch)
2017-10-04 17:12 PDT
,
Ryan Haddad
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2017-10-03 20:49:07 PDT
I suspect that this is a mistake in the test, which races parsing and navigation. Moving runTest() from inline script to load event handler may fix the problem. Ryan or Matt, would you be willing to try this out?
Ryan Haddad
Comment 2
2017-10-04 16:49:19 PDT
(In reply to Alexey Proskuryakov from
comment #1
)
> I suspect that this is a mistake in the test, which races parsing and > navigation. Moving runTest() from inline script to load event handler may > fix the problem. > > Ryan or Matt, would you be willing to try this out?
I'll look at this.
Ryan Haddad
Comment 3
2017-10-04 17:02:06 PDT
I can reproduce the failure with: run-webkit-tests --release http/tests/loading/resourceLoadStatistics/ --no-retry-failure -fg I cannot reproduce the failure after moving runTest() as suggested.
Ryan Haddad
Comment 4
2017-10-04 17:12:51 PDT
Created
attachment 322745
[details]
Patch
WebKit Commit Bot
Comment 5
2017-10-06 16:06:10 PDT
Comment on
attachment 322745
[details]
Patch Clearing flags on attachment: 322745 Committed
r223008
: <
http://trac.webkit.org/changeset/223008
>
WebKit Commit Bot
Comment 6
2017-10-06 16:06:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2017-10-06 16:07:02 PDT
<
rdar://problem/34866712
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug