RESOLVED FIXED 177672
Web Inspector: Uncaught exception with populate find keyboard shortcut 
https://bugs.webkit.org/show_bug.cgi?id=177672
Summary Web Inspector: Uncaught exception with populate find keyboard shortcut
Joseph Pecoraro
Reported 2017-09-29 11:11:26 PDT
Possible exception with populate find keyboard shortcut I've occasionally seen an exception: TypeError: null is not an object (evaluating 'focusedContentView.supportsCustomFindBanner') _populateFind @ Main.js ? @ [native code] _handleKeyDown @ KeyboardShortcut.js While I'm not sure what conditions this can happen, it does seem like focusedContentView can be null so we should protect against that.
Attachments
[PATCH] Proposed Fix (1.89 KB, patch)
2017-09-29 11:12 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-09-29 11:12:32 PDT
Created attachment 322214 [details] [PATCH] Proposed Fix
Matt Baker
Comment 2 2017-09-29 12:15:48 PDT
Comment on attachment 322214 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 3 2017-09-29 12:47:31 PDT
Comment on attachment 322214 [details] [PATCH] Proposed Fix Clearing flags on attachment: 322214 Committed r222661: <http://trac.webkit.org/changeset/222661>
WebKit Commit Bot
Comment 4 2017-09-29 12:47:33 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-09-29 12:48:16 PDT
<rdar://problem/34745385>
Note You need to log in before you can comment on or make changes to this bug.