Bug 177672 - Web Inspector: Uncaught exception with populate find keyboard shortcut
Summary: Web Inspector: Uncaught exception with populate find keyboard shortcut
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-29 11:11 PDT by Joseph Pecoraro
Modified: 2017-09-29 12:48 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.89 KB, patch)
2017-09-29 11:12 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-09-29 11:11:26 PDT 
Possible exception with populate find keyboard shortcut

I've occasionally seen an exception:

    TypeError: null is not an object (evaluating 'focusedContentView.supportsCustomFindBanner')
        _populateFind @ Main.js
        ? @ [native code]
        _handleKeyDown @ KeyboardShortcut.js

While I'm not sure what conditions this can happen, it does seem like focusedContentView can be null so we should protect against that.
Comment 1 Joseph Pecoraro 2017-09-29 11:12:32 PDT 
Created attachment 322214 [details]
[PATCH] Proposed Fix
Comment 2 Matt Baker 2017-09-29 12:15:48 PDT 
Comment on attachment 322214 [details]
[PATCH] Proposed Fix

r=me
Comment 3 WebKit Commit Bot 2017-09-29 12:47:31 PDT 
Comment on attachment 322214 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 322214

Committed r222661: <http://trac.webkit.org/changeset/222661>
Comment 4 WebKit Commit Bot 2017-09-29 12:47:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-09-29 12:48:16 PDT 
<rdar://problem/34745385>