Bug 177669 - [iOS] Remove unused pre-iOS 11 codepaths for writing to the pasteboard
Summary: [iOS] Remove unused pre-iOS 11 codepaths for writing to the pasteboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-29 10:32 PDT by Wenson Hsieh
Modified: 2017-09-29 14:38 PDT (History)
6 users (show)

See Also:


Attachments
Patch (11.38 KB, patch)
2017-09-29 10:37 PDT, Wenson Hsieh
thorton: review+
Details | Formatted Diff | Diff
Patch for landing (11.34 KB, patch)
2017-09-29 11:09 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-09-29 10:32:42 PDT
This is all just dead code, and can now be safely removed.
Comment 1 Wenson Hsieh 2017-09-29 10:37:13 PDT
Created attachment 322198 [details]
Patch
Comment 2 Tim Horton 2017-09-29 10:54:11 PDT
Comment on attachment 322198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322198&action=review

> Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:55
> +#if TARGET_OS_IOS

I think we usually don't use the platform target conditionals, and prefer PLATFORM(IOS) && !(PLATFORM(WATCHOS) || PLATFORM(APPLETV)), however sad that may be. If you don't want to say that everywhere, add a thing like ENABLE_DATA_DETECTION or HAVE_AVKIT are defined in Platform.h?
Comment 3 Wenson Hsieh 2017-09-29 11:02:00 PDT
Comment on attachment 322198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322198&action=review

>> Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:55
>> +#if TARGET_OS_IOS
> 
> I think we usually don't use the platform target conditionals, and prefer PLATFORM(IOS) && !(PLATFORM(WATCHOS) || PLATFORM(APPLETV)), however sad that may be. If you don't want to say that everywhere, add a thing like ENABLE_DATA_DETECTION or HAVE_AVKIT are defined in Platform.h?

Oh, I see! That sounds fine then. Since this is a pretty specific HAVE(), I think I'll just use the PLATFORM() macros here. With the exception of the [NSURL _title], these are things we only want to compile if UIPasteboard exposes a list of NSItemProviders, so I'm not sure it'll be very useful elsewhere. But if it is, we can probably figure out a general term to describe this.
Comment 4 Wenson Hsieh 2017-09-29 11:09:15 PDT
Created attachment 322213 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-09-29 11:53:26 PDT
Comment on attachment 322213 [details]
Patch for landing

Clearing flags on attachment: 322213

Committed r222659: <http://trac.webkit.org/changeset/222659>
Comment 6 Radar WebKit Bug Importer 2017-09-29 14:38:40 PDT
<rdar://problem/34747803>