Bug 177669 – [iOS] Remove unused pre-iOS 11 codepaths for writing to the pasteboard

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wenson Hsieh]

This is all just dead code, and can now be safely removed.

[Wenson Hsieh]

Created attachment 322198 [details]
Patch

[Tim Horton]

Comment on attachment 322198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322198&action=review

> Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:55
> +#if TARGET_OS_IOS

I think we usually don't use the platform target conditionals, and prefer PLATFORM(IOS) && !(PLATFORM(WATCHOS) || PLATFORM(APPLETV)), however sad that may be. If you don't want to say that everywhere, add a thing like ENABLE_DATA_DETECTION or HAVE_AVKIT are defined in Platform.h?

[Wenson Hsieh]

Comment on attachment 322198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322198&action=review

>> Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:55
>> +#if TARGET_OS_IOS
> 
> I think we usually don't use the platform target conditionals, and prefer PLATFORM(IOS) && !(PLATFORM(WATCHOS) || PLATFORM(APPLETV)), however sad that may be. If you don't want to say that everywhere, add a thing like ENABLE_DATA_DETECTION or HAVE_AVKIT are defined in Platform.h?

Oh, I see! That sounds fine then. Since this is a pretty specific HAVE(), I think I'll just use the PLATFORM() macros here. With the exception of the [NSURL _title], these are things we only want to compile if UIPasteboard exposes a list of NSItemProviders, so I'm not sure it'll be very useful elsewhere. But if it is, we can probably figure out a general term to describe this.

[Wenson Hsieh]

Created attachment 322213 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 322213 [details]
Patch for landing

Clearing flags on attachment: 322213

Committed r222659: <http://trac.webkit.org/changeset/222659>

[Radar WebKit Bug Importer]

<rdar://problem/34747803>