RESOLVED FIXED Bug 177667
[WK2][NETWORK_SESSION] Move some authentication-related code to avoid duplication 
https://bugs.webkit.org/show_bug.cgi?id=177667
Summary [WK2][NETWORK_SESSION] Move some authentication-related code to avoid duplica...
Chris Dumez
Reported 2017-09-29 10:16:29 PDT
Move some authentication-related code to avoid duplication.
Attachments
Patch (15.16 KB, patch)
2017-09-29 10:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (15.17 KB, patch)
2017-09-29 14:47 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-09-29 10:47:58 PDT
Created attachment 322209 [details] Patch
Alex Christensen
Comment 2 2017-09-29 14:39:02 PDT
Comment on attachment 322209 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322209&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:233 > + if ([challenge.protectionSpace.authenticationMethod isEqualTo:NSURLAuthenticationMethodServerTrust] && !NetworkProcess::singleton().canHandleHTTPSServerTrustEvaluation()) { isEqualToString
Chris Dumez
Comment 3 2017-09-29 14:47:50 PDT
Created attachment 322237 [details] Patch
Chris Dumez
Comment 4 2017-09-29 15:08:37 PDT
Comment on attachment 322237 [details] Patch Clearing flags on attachment: 322237 Committed r222667: <http://trac.webkit.org/changeset/222667>
Chris Dumez
Comment 5 2017-09-29 15:08:39 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-09-29 15:09:43 PDT
<rdar://problem/34748554>
Note You need to log in before you can comment on or make changes to this bug.