Bug 177662 - [iOS WK2] Implement -[WKContentView hasText] for compatibility with the UITextInput protocol
Summary: [iOS WK2] Implement -[WKContentView hasText] for compatibility with the UITex...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-29 09:23 PDT by Wenson Hsieh
Modified: 2017-09-30 11:52 PDT (History)
4 users (show)

See Also:

Attachments
Patch (19.98 KB, patch)
2017-09-29 10:10 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Remove unnecessary UIKit.h import (20.34 KB, patch)
2017-09-29 10:14 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-09-29 09:23:48 PDT 
Technically, -hasText is already implemented on WKContentView, but it currently always returns a bogus value of YES. Semantically, -hasText should only be YES if the content being edited is represented by a "non-zero-length string".
Comment 1 Wenson Hsieh 2017-09-29 09:24:17 PDT 
<rdar://problem/33410373>
Comment 2 Wenson Hsieh 2017-09-29 10:10:14 PDT 
Created attachment 322191 [details]
Patch
Comment 3 Wenson Hsieh 2017-09-29 10:14:30 PDT 
Created attachment 322192 [details]
Remove unnecessary UIKit.h import
Comment 4 Wenson Hsieh 2017-09-29 11:02:54 PDT 
Comment on attachment 322192 [details]
Remove unnecessary UIKit.h import

Thanks Tim!
Comment 5 WebKit Commit Bot 2017-09-29 11:33:36 PDT 
Comment on attachment 322192 [details]
Remove unnecessary UIKit.h import

Clearing flags on attachment: 322192

Committed r222654: <http://trac.webkit.org/changeset/222654>
Comment 6 WebKit Commit Bot 2017-09-29 11:33:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Wenson Hsieh 2017-09-30 11:52:26 PDT 
It looks like one of the API tests added here is flaky due to a latent bug. Fixing in https://bugs.webkit.org/show_bug.cgi?id=177698