Bug 177654 - Add a WebKit Build Archives page
Summary: Add a WebKit Build Archives page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Davis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-29 07:49 PDT by Jon Davis
Modified: 2017-10-02 10:27 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.76 KB, patch)
2017-09-29 08:02 PDT, Jon Davis
no flags Details | Formatted Diff | Diff
Patch (10.65 KB, patch)
2017-10-02 08:23 PDT, Jon Davis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2017-09-29 07:49:44 PDT
Add a page to provide downloads to WebKit Build Archives.
Comment 1 Jon Davis 2017-09-29 08:02:08 PDT
Created attachment 322184 [details]
Patch
Comment 2 Alexey Proskuryakov 2017-09-29 15:00:54 PDT
Comment on attachment 322184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322184&action=review

> Websites/webkit.org/ChangeLog:13
> +2017-09-29  Jon Davis  <jond@apple.com>
> +
> +        Add a WebKit Build Archives page
> +        https://bugs.webkit.org/show_bug.cgi?id=177654

Duplicate ChangeLog.

> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:31
> +        if ( is_wp_error($response) )

Coding style: spaces.

> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:69
> +            var date = new Date(parseInt(timestamp.innerHTML));

Can we use textContent here?

> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:70
> +            timestamp.innerHTML = date.toLocaleDateString('en', {"timeZoneName":"short","minute":"2-digit","hour":"2-digit","day":"numeric","month":"long","year":"numeric"})

Ditto.

Also, can you fix the mix of double and single quotes throughout?

> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:77
> +                if ( currentLink.length )

Coding style.

> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:83
> +                if ( currentList.length )

Coding style.

> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:92
> +            if (link.className.indexOf(window.location.hash.replace('#','')) !== -1)

Coding style: space after comma.

> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:103
> +    echo '<meta name="robots" content="nofollow" />';

Please don't use XML self-closing syntax in HTML
Comment 3 Jon Davis 2017-10-02 08:23:09 PDT
Created attachment 322377 [details]
Patch
Comment 4 WebKit Commit Bot 2017-10-02 10:26:41 PDT
Comment on attachment 322377 [details]
Patch

Clearing flags on attachment: 322377

Committed r222717: <http://trac.webkit.org/changeset/222717>
Comment 5 WebKit Commit Bot 2017-10-02 10:26:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-10-02 10:27:49 PDT
<rdar://problem/34769776>