Bug 177654 – Add a WebKit Build Archives page

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Website

[Jon Davis]

Add a page to provide downloads to WebKit Build Archives.

[Jon Davis]

Created attachment 322184 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 322184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322184&action=review

> Websites/webkit.org/ChangeLog:13
> [phone]  Jon Davis  <[e-mail]>
> +
> +        Add a WebKit Build Archives page
> +        https://bugs.webkit.org/show_bug.cgi?id=177654

Duplicate ChangeLog.

> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:31
> +        if ( is_wp_error($response) )

Coding style: spaces.

> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:69
> +            var date = new Date(parseInt(timestamp.innerHTML));

Can we use textContent here?

> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:70
> +            timestamp.innerHTML = date.toLocaleDateString('en', {"timeZoneName":"short","minute":"2-digit","hour":"2-digit","day":"numeric","month":"long","year":"numeric"})

Ditto.

Also, can you fix the mix of double and single quotes throughout?

> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:77
> +                if ( currentLink.length )

Coding style.

> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:83
> +                if ( currentList.length )

Coding style.

> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:92
> +            if (link.className.indexOf(window.location.hash.replace('#','')) !== -1)

Coding style: space after comma.

> Websites/webkit.org/wp-content/themes/webkit/build-archives.php:103
> +    echo '<meta name="robots" content="nofollow" />';

Please don't use XML self-closing syntax in HTML

[Jon Davis]

Created attachment 322377 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 322377 [details]
Patch

Clearing flags on attachment: 322377

Committed r222717: <http://trac.webkit.org/changeset/222717>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34769776>