Bug 177637 - Re-enable more pasteboard tests on iOS after r222595
Summary: Re-enable more pasteboard tests on iOS after r222595
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-28 19:43 PDT by Ryosuke Niwa
Modified: 2017-09-29 11:38 PDT (History)
6 users (show)

See Also:


Attachments
Re-enables tests (2.78 KB, patch)
2017-09-28 19:44 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (964.80 KB, application/zip)
2017-09-28 21:15 PDT, Build Bot
no flags Details
Patch (1.88 KB, patch)
2017-09-28 22:47 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-09-28 19:43:39 PDT
Re-enable more pasteboard tests on iOS after r222595
Comment 1 Ryosuke Niwa 2017-09-28 19:44:33 PDT
Created attachment 322156 [details]
Re-enables tests
Comment 2 Build Bot 2017-09-28 21:15:11 PDT
Comment on attachment 322156 [details]
Re-enables tests

Attachment 322156 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4694720

New failing tests:
editing/pasteboard/pasting-empty-html-falls-back-to-text.html
editing/pasteboard/onpaste-text-html-types.html
Comment 3 Build Bot 2017-09-28 21:15:13 PDT
Created attachment 322166 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 4 Ryosuke Niwa 2017-09-28 22:47:52 PDT
Created attachment 322172 [details]
Patch
Comment 5 Wenson Hsieh 2017-09-29 07:20:18 PDT
Comment on attachment 322172 [details]
Patch

Nice! rs=me
Comment 6 Wenson Hsieh 2017-09-29 07:50:08 PDT
As an aside, I should also see what other editing/pasteboard/ tests <http://trac.webkit.org/r222595> fixes if I additionally enable the internal settings switch for custom pasteboard data...
Comment 7 Ryosuke Niwa 2017-09-29 11:34:56 PDT
(In reply to Wenson Hsieh from comment #6)
> As an aside, I should also see what other editing/pasteboard/ tests
> <http://trac.webkit.org/r222595> fixes if I additionally enable the internal
> settings switch for custom pasteboard data...

Yeah, we might want to turn that on by default inside DRT/WTR.
Comment 8 Ryosuke Niwa 2017-09-29 11:37:30 PDT
Comment on attachment 322172 [details]
Patch

Clearing flags on attachment: 322172

Committed r222655: <http://trac.webkit.org/changeset/222655>
Comment 9 Ryosuke Niwa 2017-09-29 11:37:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-09-29 11:38:39 PDT
<rdar://problem/34743911>