Bug 177613 - Web Inspector: Remove Error icon in error message for resources it looks poor
Summary: Web Inspector: Remove Error icon in error message for resources it looks poor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-28 12:27 PDT by Joseph Pecoraro
Modified: 2017-09-28 13:19 PDT (History)
5 users (show)

See Also:


Attachments
[IMAGE] Before - wide (129.27 KB, image/png)
2017-09-28 12:28 PDT, Joseph Pecoraro
no flags Details
[IMAGE] After - wide (127.83 KB, image/png)
2017-09-28 12:28 PDT, Joseph Pecoraro
no flags Details
[IMAGE] Before - narrow (123.64 KB, image/png)
2017-09-28 12:28 PDT, Joseph Pecoraro
no flags Details
[IMAGE] After - narrow (122.65 KB, image/png)
2017-09-28 12:28 PDT, Joseph Pecoraro
no flags Details
[PATCH] Proposed Fix (1.40 KB, patch)
2017-09-28 12:29 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-09-28 12:27:42 PDT
Remove Error icon in error message for resources it looks poor.

It looks especially poor when the message is narrow and spans multiple lines, the icon is tiny and cramps the text.
Comment 1 Joseph Pecoraro 2017-09-28 12:28:05 PDT
Created attachment 322105 [details]
[IMAGE] Before - wide
Comment 2 Joseph Pecoraro 2017-09-28 12:28:17 PDT
Created attachment 322106 [details]
[IMAGE] After - wide
Comment 3 Joseph Pecoraro 2017-09-28 12:28:35 PDT
Created attachment 322107 [details]
[IMAGE] Before - narrow
Comment 4 Joseph Pecoraro 2017-09-28 12:28:45 PDT
Created attachment 322108 [details]
[IMAGE] After - narrow
Comment 5 Joseph Pecoraro 2017-09-28 12:29:24 PDT
Created attachment 322109 [details]
[PATCH] Proposed Fix
Comment 6 Matt Baker 2017-09-28 12:38:24 PDT
Comment on attachment 322109 [details]
[PATCH] Proposed Fix

Looks better! r=me
Comment 7 WebKit Commit Bot 2017-09-28 13:18:09 PDT
Comment on attachment 322109 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 322109

Committed r222630: <http://trac.webkit.org/changeset/222630>
Comment 8 WebKit Commit Bot 2017-09-28 13:18:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-09-28 13:19:23 PDT
<rdar://problem/34722580>