Bug 177574 - Web Inspector: Missing checks in DebuggerSidebarPanel for DOM debugging support
Summary: Web Inspector: Missing checks in DebuggerSidebarPanel for DOM debugging support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-27 15:40 PDT by Matt Baker
Modified: 2017-09-27 16:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.61 KB, patch)
2017-09-27 15:42 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-09-27 15:40:02 PDT 
Summary:
Missing checks in DebuggerSidebarPanel for DOM debugging support.

Check before using member variables that are conditionally constructed based on DOM debugging support (WI.domDebuggerManager.supported).
Comment 1 Matt Baker 2017-09-27 15:42:22 PDT 
Created attachment 322030 [details]
Patch
Comment 2 Joseph Pecoraro 2017-09-27 16:27:26 PDT 
Comment on attachment 322030 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2017-09-27 16:54:44 PDT 
Comment on attachment 322030 [details]
Patch

Clearing flags on attachment: 322030

Committed r222585: <http://trac.webkit.org/changeset/222585>
Comment 4 WebKit Commit Bot 2017-09-27 16:54:46 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-09-27 16:55:45 PDT 
<rdar://problem/34701913>