Bug 177570 – REGRESSION(210837): RegExp containing failed non-zero minimum greedy groups incorrectly match

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

The expression /(Q)+|Z*Z/.test("Z ") should return false but returns true.

[Michael Saboff]

Fix in progress.

[Radar WebKit Bug Importer]

<rdar://problem/34698189>

[Daniel LeCheminant]

/(Q)+|Z*Z/.test("Z ") 

*should* actually return true but e.g.

/(Q)+|(Z)+Z/.test("Z ") 

should return false

[Michael Saboff]

(In reply to Daniel LeCheminant from comment #3)
> /(Q)+|Z*Z/.test("Z ") 
> 
> *should* actually return true but e.g.
> 
> /(Q)+|(Z)+Z/.test("Z ") 
> 
> should return false

You are right, sorry for the confusion.  The RegExp in the description is wrong.

[Michael Saboff]

Created attachment 322056 [details]
Patch

[Michael Saboff]

The test failures are due to changes r222586 and are being addressed in https://bugs.webkit.org/show_bug.cgi?id=177423.

[Mark Lam]

Comment on attachment 322056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322056&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        greedy parenthesis have backtracked as far as possible.  Prior to r210837 when non-zero minimum greedy
> +        parenthesis were factored into a fixed component and then a zero-based variable component.  After

Is there a typo in the sentence "Prior to r210837..."?  I don't understand what it's trying to say.

[WebKit Commit Bot]

Comment on attachment 322056 [details]
Patch

Clearing flags on attachment: 322056

Committed r222601: <http://trac.webkit.org/changeset/222601>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Saboff]

(In reply to Mark Lam from comment #7)
> Comment on attachment 322056 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=322056&action=review
> 
> > Source/JavaScriptCore/ChangeLog:10
> > +        greedy parenthesis have backtracked as far as possible.  Prior to r210837 when non-zero minimum greedy
> > +        parenthesis were factored into a fixed component and then a zero-based variable component.  After
> 
> Is there a typo in the sentence "Prior to r210837..."?  I don't understand
> what it's trying to say.

I checked in a fix to that sentence.