Bug 177560 - Blurry captions on retina screens.
Summary: Blurry captions on retina screens.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-27 12:23 PDT by Jeremy Jones
Modified: 2017-11-02 11:26 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.52 KB, patch)
2017-09-27 12:29 PDT, Jeremy Jones 		jer.noble: review+
Details | Formatted Diff | Diff
Patch for landing (2.52 KB, patch)
2017-10-03 12:14 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2017-09-27 12:23:58 PDT 
Blurry captions on retina screens.
Comment 1 Jeremy Jones 2017-09-27 12:24:54 PDT 
rdar://problem/17913388
Comment 2 Jeremy Jones 2017-09-27 12:29:14 PDT 
Created attachment 321997 [details]
Patch
Comment 3 Jer Noble 2017-10-03 12:09:03 PDT 
Comment on attachment 321997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321997&action=review

> Source/WebCore/html/shadow/MediaControlElements.cpp:1369
> +        videoBox.setWidth(videoBox.width()*deviceScaleFactor);
> +        videoBox.setHeight(videoBox.height()*deviceScaleFactor);

Nit: spaces around the "*".
Comment 4 Jeremy Jones 2017-10-03 12:14:47 PDT 
Created attachment 322559 [details]
Patch for landing
Comment 5 Jeremy Jones 2017-10-03 12:24:42 PDT 
(In reply to Jer Noble from comment #3)
> Comment on attachment 321997 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=321997&action=review
> 
> > Source/WebCore/html/shadow/MediaControlElements.cpp:1369
> > +        videoBox.setWidth(videoBox.width()*deviceScaleFactor);
> > +        videoBox.setHeight(videoBox.height()*deviceScaleFactor);
> 
> Nit: spaces around the "*".

Done.
Comment 6 WebKit Commit Bot 2017-10-09 10:56:38 PDT 
Comment on attachment 322559 [details]
Patch for landing

Clearing flags on attachment: 322559

Committed r223052: <http://trac.webkit.org/changeset/223052>