Bug 177550 – [GStreamer] Try to play AVC codec even if H.264 decoder only advertises byte-stream profile.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Charlie Turner]

Try to play AVC codec even if H.264 decoder only advertises byte-stream profile.

[Jon Lee]

Can you discuss a little bit more your use case?

[Charlie Turner]

It seems I've accidentally pulled the trigger on uploading this patch before it's ready. This is specific to GTK/WPE, sorry for the false alarm.

[Charlie Turner]

Created attachment 322123 [details]
Patch

[Enrique Ocaña]

Looks good. I'm assuming that playbin properly places an h264parse element to convert from avc to byte-stream, right?

[Charlie Turner]

> I'm assuming that playbin properly places an h264parse element to convert from avc to byte-stream, right?

That's correct. The GstH264Parse element will be inserted by playbin when the H.264 decoder only advertises byte-stream.

While this isn't the case for a typical desktop GStreamer using libav, whose decoder supports both AVC and byte-stream. But on embedded systems like the Pi, the OpenMAX decoder only advertises byte-stream, and in this case the playbin will automatically convert it for us.

That's why we didn't notice any issues on desktop, because the filter did succeed, it's just not necessary with the ability of our pipeline to dynamically convert to bytestream if needed.

[Carlos Alberto Lopez Perez]

Comment on attachment 322123 [details]
Patch

r=me if this looks good for Enrique :)

[Charlie Turner]

Created attachment 322369 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 322369 [details]
Patch for landing

Clearing flags on attachment: 322369

Committed r222707: <http://trac.webkit.org/changeset/222707>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.