Bug 177544 – Add ports 6679 and 6697 (IRC SSL) to port blacklist

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brent Fulgham]

Update our port blocking blacklist to match Chrome's list.

We should not see any compatibility impact here, since Chrome has been blocking this port for a long time.

[Brent Fulgham]

<rdar://problem/34666525>

[Brent Fulgham]

Created attachment 321962 [details]
Patch

[Build Bot]

Comment on attachment 321962 [details]
Patch

Attachment 321962 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4676747

New failing tests:
security/block-test.html

[Build Bot]

Created attachment 321968 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Brent Fulgham]

Created attachment 321969 [details]
Patch

[Alex Christensen]

Comment on attachment 321969 [details]
Patch

Wikipedia says 6697 is the official number and 6679 the unofficial number.  Do we want to block both?

[Brent Fulgham]

(In reply to Alex Christensen from comment #6)
> Comment on attachment 321969 [details]
> Patch
> 
> Wikipedia says 6697 is the official number and 6679 the unofficial number. 
> Do we want to block both?

Yes. :-)

[Sam Weinig]

Please file a bug to update the port blocking part of the fetch spec, https://fetch.spec.whatwg.org/#port-blocking.

[Brent Fulgham]

(In reply to Brent Fulgham from comment #7)
> (In reply to Alex Christensen from comment #6)
> > Comment on attachment 321969 [details]
> > Patch
> > 
> > Wikipedia says 6697 is the official number and 6679 the unofficial number. 
> > Do we want to block both?
> 
> Yes. :-)

Oh, wait =- I'm not sure. I don't think Chrome does, so we might create some compatibility issues if we did.

[Sam Weinig]

Comment on attachment 321969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321969&action=review

> Source/WebCore/platform/URL.cpp:1281
> +        6679, // Alternate IRC SSL [Apple addition]

Why [Apple addition] if this came from Chrome?

[Brent Fulgham]

(In reply to Sam Weinig from comment #10)
> Comment on attachment 321969 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=321969&action=review
> 
> > Source/WebCore/platform/URL.cpp:1281
> > +        6679, // Alternate IRC SSL [Apple addition]
> 
> Why [Apple addition] if this came from Chrome?

It's an Apple addition (in our sources) to a list provided by Mozilla.

I could mark it as Chrome, but I don't think we've done that with other similar changes.

[Brent Fulgham]

(In reply to Alex Christensen from comment #6)
> Comment on attachment 321969 [details]
> Patch
> 
> Wikipedia says 6697 is the official number and 6679 the unofficial number. 
> Do we want to block both?

I checked with some people, and we decided that yes, we should block both. I've updated the bug to reflect this.

[Brent Fulgham]

Created attachment 322095 [details]
Patch

[Brent Fulgham]

Committed r222623: <http://trac.webkit.org/changeset/222623>