Bug 177531 - REGRESSION (r222040): Crash navigating out of gfycat.com url
Summary: REGRESSION (r222040): Crash navigating out of gfycat.com url
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-27 04:42 PDT by Antti Koivisto
Modified: 2017-09-27 08:35 PDT (History)
11 users (show)

See Also:

Attachments
patch (8.09 KB, patch)
2017-09-27 04:54 PDT, Antti Koivisto 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-09-27 04:42:18 PDT 
1) https://gfycat.com/HoarseMadeupEuropeanpolecat
2) press back
Comment 1 Antti Koivisto 2017-09-27 04:44:46 PDT 
<rdar://problem/34602601>
Comment 2 Antti Koivisto 2017-09-27 04:54:26 PDT 
Created attachment 321954 [details]
patch
Comment 3 Geoffrey Garen 2017-09-27 08:03:18 PDT 
Comment on attachment 321954 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321954&action=review

r=me

> Source/WebCore/dom/ElementRareData.h:111
> +    void setHasCSSAnimation(bool b) { m_hasCSSAnimation = b; }

WebKit style says the argument name should be "hasCSSAnimation".
Comment 4 Antti Koivisto 2017-09-27 08:33:30 PDT 
https://trac.webkit.org/r222554
Comment 5 Antti Koivisto 2017-09-27 08:35:53 PDT 
> WebKit style says the argument name should be "hasCSSAnimation".

That seems bit redundant. I called it 'value' which looks like a Common WebKit Pattern.