Bug 177522 - Web Inspector: Remove unused parameter of Page.reload
Summary: Web Inspector: Remove unused parameter of Page.reload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-26 22:32 PDT by Joseph Pecoraro
Modified: 2017-10-02 11:10 PDT (History)
9 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (7.65 KB, patch)
2017-09-26 23:06 PDT, Joseph Pecoraro 		mattbaker: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-09-26 22:32:22 PDT 
Web Inspector: Remove unused parameter of Page.reload

We have never used it in our frontend and it doesn't seem like we will soon.
Comment 1 Joseph Pecoraro 2017-09-26 23:06:20 PDT 
Created attachment 321938 [details]
[PATCH] Proposed Fix
Comment 2 Build Bot 2017-09-26 23:08:18 PDT 
Attachment 321938 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Matt Baker 2017-09-27 08:36:35 PDT 
Comment on attachment 321938 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=321938&action=review

r=me

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Remove this.
Comment 4 Joseph Pecoraro 2017-09-27 10:57:49 PDT 
<https://trac.webkit.org/changeset/222560/webkit>
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:14:50 PDT 
<rdar://problem/34692859>