RESOLVED FIXED 177516
[PAL] Move HysteresisActivity into PAL 
https://bugs.webkit.org/show_bug.cgi?id=177516
Summary [PAL] Move HysteresisActivity into PAL
Don Olmstead
Reported 2017-09-26 16:40:16 PDT
Move the HysteresisActivity file into PAL
Attachments
Patch (35.21 KB, patch)
2017-09-27 14:36 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (34.72 KB, patch)
2017-09-27 14:51 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (36.03 KB, patch)
2017-09-27 15:58 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (37.45 KB, patch)
2017-09-27 18:09 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (32.76 KB, patch)
2017-09-28 10:57 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2017-09-27 14:36:42 PDT
Created attachment 322017 [details] Patch
Ross Kirsling
Comment 2 2017-09-27 14:51:28 PDT
Created attachment 322020 [details] Patch
Build Bot
Comment 3 2017-09-27 15:49:06 PDT
Attachment 322020 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:210: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:342: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WebKit/WebProcess/WebProcess.cpp:165: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 4 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ross Kirsling
Comment 4 2017-09-27 15:58:58 PDT
Created attachment 322035 [details] Patch
Build Bot
Comment 5 2017-09-27 16:02:50 PDT
Attachment 322035 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:210: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:342: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WebKit/WebProcess/WebProcess.cpp:165: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp:44: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 5 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ross Kirsling
Comment 6 2017-09-27 18:09:49 PDT
Created attachment 322050 [details] Patch
Build Bot
Comment 7 2017-09-27 18:12:39 PDT
Attachment 322050 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:210: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:342: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WebKit/WebProcess/WebProcess.cpp:165: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp:44: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 4 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 8 2017-09-28 10:09:33 PDT
Comment on attachment 322050 [details] Patch Rejecting attachment 322050 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 322050, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: file Source/WebKit/Shared/WebSQLiteDatabaseTracker.cpp patching file Source/WebKit/Shared/WebSQLiteDatabaseTracker.h patching file Source/WebKit/WebProcess/WebPage/WebPage.cpp patching file Source/WebKit/WebProcess/WebPage/WebPage.h patching file Source/WebKit/WebProcess/WebProcess.cpp patching file Source/WebKit/WebProcess/WebProcess.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/4688511
Ross Kirsling
Comment 9 2017-09-28 10:57:02 PDT
Created attachment 322099 [details] Patch
Build Bot
Comment 10 2017-09-28 10:58:40 PDT
Attachment 322099 [details] did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:210: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:342: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WebKit/WebProcess/WebProcess.cpp:165: More than one command on the same line in if [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp:44: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 4 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 11 2017-09-28 11:37:27 PDT
Comment on attachment 322099 [details] Patch Clearing flags on attachment: 322099 Committed r222619: <http://trac.webkit.org/changeset/222619>
WebKit Commit Bot
Comment 12 2017-09-28 11:37:29 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 13 2017-09-28 11:38:30 PDT
<rdar://problem/34720098>
Note You need to log in before you can comment on or make changes to this bug.