Bug 177514 - Web Automation: overflow:hidden elements with no children are mistakenly reported as not visible
Summary: Web Automation: overflow:hidden elements with no children are mistakenly repo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-26 16:01 PDT by BJ Burg
Modified: 2017-09-26 17:02 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2017-09-26 16:03 PDT, BJ Burg
joepeck: review+
bburg: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-09-26 16:01:02 PDT
..............
Comment 1 BJ Burg 2017-09-26 16:01:13 PDT
<rdar://problem/31936291>
Comment 2 BJ Burg 2017-09-26 16:03:35 PDT
Created attachment 321883 [details]
Patch
Comment 3 Joseph Pecoraro 2017-09-26 16:14:27 PDT
Comment on attachment 321883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321883&action=review

r=me

> Source/WebKit/ChangeLog:12
> +        to check for the case where the element has no children and return 'false'.

I'd use backticks `false` to avoid string confusion, but this is a ChangeLog after all, so whatever.
Comment 4 BJ Burg 2017-09-26 17:02:06 PDT
Committed r222536: <http://trac.webkit.org/changeset/222536>