Bug 177513 - Expose setShouldSuppressFirstResponderChanges() as WKView SPI
Summary: Expose setShouldSuppressFirstResponderChanges() as WKView SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: iting_liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-26 15:56 PDT by iting_liu
Modified: 2017-09-27 15:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch v1. (2.84 KB, patch)
2017-09-26 16:36 PDT, iting_liu 		wenson_hsieh: review+
Details | Formatted Diff | Diff
Patch v2. Added WK_API_AVAILABLE. (2.88 KB, patch)
2017-09-27 13:04 PDT, iting_liu 		no flags Details | Formatted Diff | Diff
V3. (2.88 KB, patch)
2017-09-27 13:20 PDT, iting_liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description iting_liu 2017-09-26 15:56:42 PDT 
Safari is still using WKView, so even though we already have such SPI on WKWebView, we still need one for WKView.
Comment 1 iting_liu 2017-09-26 15:58:35 PDT 
<rdar://problem/34669220> Allow calling WebViewImpl::setShouldSuppressFirstResponderChanges from WKView and iOS WKWebView
Comment 2 iting_liu 2017-09-26 16:36:02 PDT 
Created attachment 321889 [details]
Patch v1.
Comment 3 Wenson Hsieh 2017-09-27 11:29:44 PDT 
Comment on attachment 321889 [details]
Patch v1.

View in context: https://bugs.webkit.org/attachment.cgi?id=321889&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h:135
> +- (void)_setShouldSuppressFirstResponderChanges:(BOOL)shouldSuppress;

We should add an availability macro here (even if it's missing from most of the surrounding SPI :/)
Comment 4 iting_liu 2017-09-27 13:01:13 PDT 
Comment on attachment 321889 [details]
Patch v1.

View in context: https://bugs.webkit.org/attachment.cgi?id=321889&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKViewPrivate.h:135
>> +- (void)_setShouldSuppressFirstResponderChanges:(BOOL)shouldSuppress;
> 
> We should add an availability macro here (even if it's missing from most of the surrounding SPI :/)

I'll add WK_API_AVAILABLE(macosx(WK_MAC_TBA)) here as we discussed.
Comment 5 iting_liu 2017-09-27 13:04:31 PDT 
Created attachment 322007 [details]
Patch v2. Added WK_API_AVAILABLE.
Comment 6 iting_liu 2017-09-27 13:20:40 PDT 
Created attachment 322011 [details]
V3.

Updated "Reviewed by"
Comment 7 WebKit Commit Bot 2017-09-27 14:44:23 PDT 
Comment on attachment 322011 [details]
V3.

Clearing flags on attachment: 322011

Committed r222577: <http://trac.webkit.org/changeset/222577>
Comment 8 WebKit Commit Bot 2017-09-27 14:44:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-09-27 15:20:06 PDT 
<rdar://problem/34699348>