Bug 177511 - Make it possible to easily get verbose ninja output from build-webkit
Summary: Make it possible to easily get verbose ninja output from build-webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks: 177512
  Show dependency tree / graph
 
Reported: 2017-09-26 15:33 PDT by Tim Horton
Modified: 2017-09-27 12:14 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.16 KB, patch)
2017-09-26 15:33 PDT, Tim Horton 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-09-26 15:33:35 PDT 
Make it possible to easily get verbose ninja output from build-webkit
Comment 1 Tim Horton 2017-09-26 15:33:49 PDT 
Created attachment 321880 [details]
Patch
Comment 2 Sam Weinig 2017-09-26 17:03:56 PDT 
Comment on attachment 321880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321880&action=review

Seems fine. Kind of weird using ENV to communicate to buildCMakeGeneratedProject. Seems like passing an argument would be clearer.

> Tools/ChangeLog:15
> +        Add Ninja verbosity arguments to @makeArgs, which are appended
> +        after the -- and thus handed to ninja; the previous implementation

Inconsistent on capitalization of Ninja.
Comment 3 Tim Horton 2017-09-26 18:00:47 PDT 
https://trac.webkit.org/changeset/222538/webkit
Comment 4 Radar WebKit Bug Importer 2017-09-27 12:14:43 PDT 
<rdar://problem/34692854>