Bug 177502 – AX: Several ARIA roles with presentational children are exposing children

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

The following ARIA roles have presentational children (and thus should not include those children in the accessibility tree):

* menuitemcheckbox (a 1.1 change)
* menuitemradio (a 1.1 change)
* separator
* math

We're exposing the children.

[Radar WebKit Bug Importer]

<rdar://problem/34665059>

[Joanmarie Diggs]

Created attachment 321862 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 321862 [details]
Patch

Clearing flags on attachment: 321862

Committed r222525: <http://trac.webkit.org/changeset/222525>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Matt Lewis]

This caused the test inspector/dom/getAccessibilityPropertiesForNode.html to start failing consistently on macOS:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdom%2FgetAccessibilityPropertiesForNode.html

build results:
https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r222525%20(4747)/results.html

diff:

--- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/inspector/dom/getAccessibilityPropertiesForNode-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/inspector/dom/getAccessibilityPropertiesForNode-actual.txt
@@ -484,7 +484,6 @@
     exists: true
     label: 
     role: separator
-    childNodeIds.length: 1
     parentNodeId: exists
 
 <div role="doc-notice">doc-notice</div>

[Matt Lewis]

Reverted r222525 for reason:

This caused a consistent failure in the test inspector/dom/getAccessibilityPropertiesForNode.html .

Committed r222535: <http://trac.webkit.org/changeset/222535>

[Joanmarie Diggs]

Ouch. Sorry I missed your IRC ping. Especially given your quick rollout. :( But that test just needs to be rebased. New patch coming up....

[Joanmarie Diggs]

Created attachment 321909 [details]
original patch with updated results inspector test

[WebKit Commit Bot]

Comment on attachment 321909 [details]
original patch with updated results inspector test

Clearing flags on attachment: 321909

Committed r222544: <http://trac.webkit.org/changeset/222544>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.