Bug 177502 - AX: Several ARIA roles with presentational children are exposing children
Summary: AX: Several ARIA roles with presentational children are exposing children
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joanmarie Diggs
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-26 13:26 PDT by Joanmarie Diggs
Modified: 2017-09-26 19:21 PDT (History)
10 users (show)

See Also:


Attachments
Patch (6.04 KB, patch)
2017-09-26 13:42 PDT, Joanmarie Diggs
no flags Details | Formatted Diff | Diff
original patch with updated results inspector test (6.58 KB, patch)
2017-09-26 17:41 PDT, Joanmarie Diggs
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs 2017-09-26 13:26:52 PDT
The following ARIA roles have presentational children (and thus should not include those children in the accessibility tree):

* menuitemcheckbox (a 1.1 change)
* menuitemradio (a 1.1 change)
* separator
* math

We're exposing the children.
Comment 1 Radar WebKit Bug Importer 2017-09-26 13:27:17 PDT
<rdar://problem/34665059>
Comment 2 Joanmarie Diggs 2017-09-26 13:42:08 PDT
Created attachment 321862 [details]
Patch
Comment 3 WebKit Commit Bot 2017-09-26 14:51:07 PDT
Comment on attachment 321862 [details]
Patch

Clearing flags on attachment: 321862

Committed r222525: <http://trac.webkit.org/changeset/222525>
Comment 4 WebKit Commit Bot 2017-09-26 14:51:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Matt Lewis 2017-09-26 16:40:43 PDT
This caused the test inspector/dom/getAccessibilityPropertiesForNode.html to start failing consistently on macOS:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdom%2FgetAccessibilityPropertiesForNode.html

build results:
https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r222525%20(4747)/results.html

diff:

--- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/inspector/dom/getAccessibilityPropertiesForNode-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/inspector/dom/getAccessibilityPropertiesForNode-actual.txt
@@ -484,7 +484,6 @@
     exists: true
     label: 
     role: separator
-    childNodeIds.length: 1
     parentNodeId: exists
 
 <div role="doc-notice">doc-notice</div>
Comment 6 Matt Lewis 2017-09-26 16:59:18 PDT
Reverted r222525 for reason:

This caused a consistent failure in the test inspector/dom/getAccessibilityPropertiesForNode.html .

Committed r222535: <http://trac.webkit.org/changeset/222535>
Comment 7 Joanmarie Diggs 2017-09-26 17:08:54 PDT
Ouch. Sorry I missed your IRC ping. Especially given your quick rollout. :( But that test just needs to be rebased. New patch coming up....
Comment 8 Joanmarie Diggs 2017-09-26 17:41:41 PDT
Created attachment 321909 [details]
original patch with updated results inspector test
Comment 9 WebKit Commit Bot 2017-09-26 19:21:15 PDT
Comment on attachment 321909 [details]
original patch with updated results inspector test

Clearing flags on attachment: 321909

Committed r222544: <http://trac.webkit.org/changeset/222544>
Comment 10 WebKit Commit Bot 2017-09-26 19:21:16 PDT
All reviewed patches have been landed.  Closing bug.