Bug 177498 - AX: ARIA grids claim to be multiselectable even with aria-multiselectable is set to false
Summary: AX: ARIA grids claim to be multiselectable even with aria-multiselectable is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joanmarie Diggs
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-26 12:22 PDT by Joanmarie Diggs
Modified: 2017-09-26 15:19 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.80 KB, patch)
2017-09-26 12:26 PDT, Joanmarie Diggs 		no flags Details | Formatted Diff | Diff
patch for landing (5.65 KB, patch)
2017-09-26 15:01 PDT, Joanmarie Diggs 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs 2017-09-26 12:22:04 PDT 
ARIA grids claim to be multiselectable even with aria-multiselectable is set to false.
Comment 1 Radar WebKit Bug Importer 2017-09-26 12:22:35 PDT 
<rdar://problem/34662913>
Comment 2 Joanmarie Diggs 2017-09-26 12:26:27 PDT 
Created attachment 321855 [details]
Patch
Comment 3 chris fleizach 2017-09-26 14:50:37 PDT 
Comment on attachment 321855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321855&action=review

> Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:88
> +    if (equalLettersIgnoringASCIICase(ariaMultiSelectable, "false"))

I think you can write just like

return !equalLettersIgnoringASCIICase(ariaMultiSelectable, "false");
Comment 4 Joanmarie Diggs 2017-09-26 15:01:04 PDT 
Created attachment 321877 [details]
patch for landing
Comment 5 WebKit Commit Bot 2017-09-26 15:19:15 PDT 
Comment on attachment 321877 [details]
patch for landing

Clearing flags on attachment: 321877

Committed r222527: <http://trac.webkit.org/changeset/222527>
Comment 6 WebKit Commit Bot 2017-09-26 15:19:17 PDT 
All reviewed patches have been landed.  Closing bug.