Bug 177481 – Create bindings for WebGL2's versions of compressedTexImage2D.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Ms2ger (he/him; ⌚ UTC+1/+2)]

.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 321807 [details]
Patch

[Zan Dobersek]

Comment on attachment 321807 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321807&action=review

> Source/WebCore/html/canvas/WebGLRenderingContext.idl:40
> +    void compressedTexImage2D(GLenum target, GLint level, GLenum internalformat,
> +                              GLsizei width, GLsizei height, GLint border,
> +                              ArrayBufferView data);

This deserves a comment, explaining why it can't be placed under WebGLRenderingContextBase. It should also probably be written out in a single line.

I'll defer to Dino or Alex to confirm this approach is optimal.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 321943 [details]
Patch

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Dino?

[Zan Dobersek]

Comment on attachment 321943 [details]
Patch

Let's move on with this. Please also add a comment to the addition in WebGLRenderingContext.idl.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 322999 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 322999 [details]
Patch

Rejecting attachment 322999 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 322999, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Zan Dobersek found in /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/4779182

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 323003 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 323003 [details]
Patch

Clearing flags on attachment: 323003

Committed r222974: <http://trac.webkit.org/changeset/222974>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34853331>