Bug 177480 - Make PolicyAction an encodable enum class
Summary: Make PolicyAction an encodable enum class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-25 21:48 PDT by Alex Christensen
Modified: 2017-09-27 12:15 PDT (History)
6 users (show)

See Also:

Attachments
Patch (40.93 KB, patch)
2017-09-25 21:56 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (41.09 KB, patch)
2017-09-25 22:28 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-09-25 21:48:21 PDT 
Make PolicyAction an encodable enum class
Comment 1 Alex Christensen 2017-09-25 21:56:25 PDT 
Created attachment 321789 [details]
Patch
Comment 2 Antti Koivisto 2017-09-25 22:00:19 PDT 
Comment on attachment 321789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321789&action=review

> Source/WebKit/UIProcess/WebPageProxy.messages.in:102
> +    DecidePolicyForNavigationAction(uint64_t frameID, struct WebCore::SecurityOriginData frameSecurityOrigin, uint64_t navigationID, struct WebKit::NavigationActionData navigationActionData, struct WebKit::FrameInfoData originatingFrameInfoData, uint64_t originatingPageID, WebCore::ResourceRequest originalRequest, WebCore::ResourceRequest request, uint64_t listenerID, WebKit::UserData userData) -> (uint64_t newNavigationID, enum WebCore::PolicyAction policyAction, WebKit::DownloadID downloadID, struct WebKit::WebsitePolicies websitePolicies) Delayed

Would be nice make these sane at some point (by packing all the million arguments into a struct for example).
Comment 3 Antti Koivisto 2017-09-25 22:00:31 PDT 
r=me
Comment 4 Alex Christensen 2017-09-25 22:28:53 PDT 
Created attachment 321795 [details]
Patch
Comment 5 Alex Christensen 2017-09-25 22:52:59 PDT 
http://trac.webkit.org/r222492
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:15:55 PDT 
<rdar://problem/34692891>