Currently the default font family preferences are defined for PLATFORM(COCOA) and (PLATFORM(GTK) || PLATFORM(WPE)) and there's no definitions for the other ports. It seems like we can use (PLATFORM(GTK) || PLATFORM(WPE))'s one as a default case. #if PLATFORM(COCOA) #define FOR_EACH_WEBKIT_FONT_FAMILY_PREFERENCE(macro) \ macro(StandardFontFamily, standardFontFamily, String, String, "Times", "", "") \ macro(CursiveFontFamily, cursiveFontFamily, String, String, DEFAULT_CURSIVE_FONT_FAMILY, "", "") \ macro(FantasyFontFamily, fantasyFontFamily, String, String, "Papyrus", "", "") \ macro(FixedFontFamily, fixedFontFamily, String, String, "Courier", "", "") \ macro(SansSerifFontFamily, sansSerifFontFamily, String, String, "Helvetica", "", "") \ macro(SerifFontFamily, serifFontFamily, String, String, "Times", "", "") \ macro(PictographFontFamily, pictographFontFamily, String, String, "Apple Color Emoji", "", "") \ \ #elif PLATFORM(GTK) || PLATFORM(WPE) #define FOR_EACH_WEBKIT_FONT_FAMILY_PREFERENCE(macro) \ macro(StandardFontFamily, standardFontFamily, String, String, "Times", "", "") \ macro(CursiveFontFamily, cursiveFontFamily, String, String, "Comic Sans MS", "", "") \ macro(FantasyFontFamily, fantasyFontFamily, String, String, "Impact", "", "") \ macro(FixedFontFamily, fixedFontFamily, String, String, "Courier New", "", "") \ macro(SansSerifFontFamily, sansSerifFontFamily, String, String, "Helvetica", "", "") \ macro(SerifFontFamily, serifFontFamily, String, String, "Times", "", "") \ macro(PictographFontFamily, pictographFontFamily, String, String, "Times", "", "") \ \ #endif
Created attachment 321786 [details] Patch
Comment on attachment 321786 [details] Patch r=me
Comment on attachment 321786 [details] Patch Clearing flags on attachment: 321786 Committed r222490: <http://trac.webkit.org/changeset/222490>
All reviewed patches have been landed. Closing bug.
<rdar://problem/34692895>