Bug 177479 – [WinCairo] Share default value of font family preferences among non-cocoa builds

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Yoshiaki Jitsukawa]

Currently the default font family preferences are defined for
 PLATFORM(COCOA) and (PLATFORM(GTK) || PLATFORM(WPE))
and there's no definitions for the other ports.

It seems like we can use (PLATFORM(GTK) || PLATFORM(WPE))'s one as a default case.

#if PLATFORM(COCOA)

#define FOR_EACH_WEBKIT_FONT_FAMILY_PREFERENCE(macro) \
    macro(StandardFontFamily, standardFontFamily, String, String, "Times", "", "") \
    macro(CursiveFontFamily, cursiveFontFamily, String, String, DEFAULT_CURSIVE_FONT_FAMILY, "", "") \
    macro(FantasyFontFamily, fantasyFontFamily, String, String, "Papyrus", "", "") \
    macro(FixedFontFamily, fixedFontFamily, String, String, "Courier", "", "") \
    macro(SansSerifFontFamily, sansSerifFontFamily, String, String, "Helvetica", "", "") \
    macro(SerifFontFamily, serifFontFamily, String, String, "Times", "", "") \
    macro(PictographFontFamily, pictographFontFamily, String, String, "Apple Color Emoji", "", "") \
    \

#elif PLATFORM(GTK) || PLATFORM(WPE)

#define FOR_EACH_WEBKIT_FONT_FAMILY_PREFERENCE(macro) \
    macro(StandardFontFamily, standardFontFamily, String, String, "Times", "", "") \
    macro(CursiveFontFamily, cursiveFontFamily, String, String, "Comic Sans MS", "", "") \
    macro(FantasyFontFamily, fantasyFontFamily, String, String, "Impact", "", "") \
    macro(FixedFontFamily, fixedFontFamily, String, String, "Courier New", "", "") \
    macro(SansSerifFontFamily, sansSerifFontFamily, String, String, "Helvetica", "", "") \
    macro(SerifFontFamily, serifFontFamily, String, String, "Times", "", "") \
    macro(PictographFontFamily, pictographFontFamily, String, String, "Times", "", "") \
    \

#endif

[Yoshiaki Jitsukawa]

Created attachment 321786 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 321786 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 321786 [details]
Patch

Clearing flags on attachment: 321786

Committed r222490: <http://trac.webkit.org/changeset/222490>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34692895>