Bug 177469 – Web Inspector: Add loading indicator next to resources in the Network Tab

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Add loading indicator next to resources in the Network Tab

The Resources tab shows a loading indicator for resources that are loading. The Network tab (both modern and old) doesn't, but it should!

[Joseph Pecoraro]

Created attachment 321754 [details]
[IMAGE] Loading Indicator - LTR

[Joseph Pecoraro]

Created attachment 321755 [details]
[IMAGE] Loading Indicator - RTL

[Joseph Pecoraro]

Created attachment 321756 [details]
[PATCH] Proposed Fix

[Matt Baker]

Comment on attachment 321756 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=321756&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/Resource.js:847
> +    {

I'd make this a read-only property and put it after `Resource.prototype.finished get`.

> Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js:318
> +        } else {

Could be:

} else if (this._spinner) {

[Joseph Pecoraro]

Comment on attachment 321756 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=321756&action=review

>> Source/WebInspectorUI/UserInterface/Models/Resource.js:847
>> +    {
> 
> I'd make this a read-only property and put it after `Resource.prototype.finished get`.

Simply because we have a `finished` I didn't want to put a property `loading` since they sound to me like opposites but they aren't. So I made this a method so its is hopefully more obvious this will get you a complete result checking all state.

[WebKit Commit Bot]

Comment on attachment 321756 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 321756

Committed r222485: <http://trac.webkit.org/changeset/222485>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34692901>