Bug 177458 - Followup (r222427): SynchronizedFixedQueue should not have a public constructor
Summary: Followup (r222427): SynchronizedFixedQueue should not have a public constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-25 13:05 PDT by Said Abou-Hallawa
Modified: 2017-09-27 12:17 PDT (History)
11 users (show)

See Also:

Attachments
Patch (9.17 KB, patch)
2017-09-25 13:12 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (8.76 KB, patch)
2017-09-26 15:13 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2017-09-25 13:05:31 PDT 
Since SynchronizedFixedQueue is now derived from ThreadSafeRefCounted<SynchronizedFixedQueue>, the standard way to have an instance of it is to call SynchronizedFixedQueue::create() which returns a Ref<SynchronizedFixedQueue>. Now it does not make since to still have the constructor public.
Comment 1 Said Abou-Hallawa 2017-09-25 13:12:26 PDT 
Created attachment 321730 [details]
Patch
Comment 2 Tim Horton 2017-09-26 14:43:43 PDT 
Comment on attachment 321730 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321730&action=review

> Source/WTF/ChangeLog:10
> +        which returns a Ref<SynchronizedFixedQueue>. Now it does not make since to still

s/since/sense/
Comment 3 Said Abou-Hallawa 2017-09-26 15:13:53 PDT 
Created attachment 321878 [details]
Patch
Comment 4 WebKit Commit Bot 2017-09-26 15:40:54 PDT 
Comment on attachment 321878 [details]
Patch

Clearing flags on attachment: 321878

Committed r222530: <http://trac.webkit.org/changeset/222530>
Comment 5 WebKit Commit Bot 2017-09-26 15:40:56 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:17:50 PDT 
<rdar://problem/34692977>