Bug 177455 - Make StoredCredentials an enum class and rename its header
Summary: Make StoredCredentials an enum class and rename its header
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 177474
  Show dependency tree / graph
 
Reported: 2017-09-25 12:29 PDT by Chris Dumez
Modified: 2017-09-27 12:18 PDT (History)
8 users (show)

See Also:

Attachments
Patch (120.97 KB, patch)
2017-09-25 12:31 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (1.34 KB, patch)
2017-09-26 10:02 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-09-25 12:29:11 PDT 
Make StoredCredentials an enum class and rename its header for clarity. This was error-prone because 0 meant "allow" and and 1 meant "do not allow". It was trivial to convert it to a boolean by mistake and get the opposite behavior.
Comment 1 Chris Dumez 2017-09-25 12:31:49 PDT 
Created attachment 321720 [details]
Patch
Comment 2 WebKit Commit Bot 2017-09-25 14:17:48 PDT 
Comment on attachment 321720 [details]
Patch

Clearing flags on attachment: 321720

Committed r222467: <http://trac.webkit.org/changeset/222467>
Comment 3 WebKit Commit Bot 2017-09-25 14:17:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Chris Dumez 2017-09-26 09:59:34 PDT 
Forgot enum *class*.
Comment 5 Chris Dumez 2017-09-26 10:02:47 PDT 
Created attachment 321830 [details]
Patch
Comment 6 WebKit Commit Bot 2017-09-26 13:36:33 PDT 
Comment on attachment 321830 [details]
Patch

Clearing flags on attachment: 321830

Committed r222519: <http://trac.webkit.org/changeset/222519>
Comment 7 WebKit Commit Bot 2017-09-26 13:36:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:18:04 PDT 
<rdar://problem/34692984>