Bug 177443 - Make progress on getting Mac CMake building again
Summary: Make progress on getting Mac CMake building again
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-25 11:08 PDT by Tim Horton
Modified: 2017-09-27 12:18 PDT (History)
2 users (show)

See Also:

Attachments
Patch (8.15 KB, patch)
2017-09-25 11:09 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (8.38 KB, patch)
2017-09-25 11:23 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-09-25 11:08:50 PDT 
Make progress on getting Mac CMake building again
Comment 1 Tim Horton 2017-09-25 11:09:54 PDT 
Created attachment 321704 [details]
Patch
Comment 2 WebKit Commit Bot 2017-09-25 11:10:53 PDT 
Comment on attachment 321704 [details]
Patch

Rejecting attachment 321704 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 321704, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/4651048
Comment 3 Tim Horton 2017-09-25 11:23:26 PDT 
Created attachment 321708 [details]
Patch
Comment 4 WebKit Commit Bot 2017-09-25 12:03:04 PDT 
Comment on attachment 321708 [details]
Patch

Clearing flags on attachment: 321708

Committed r222452: <http://trac.webkit.org/changeset/222452>
Comment 5 WebKit Commit Bot 2017-09-25 12:03:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:18:20 PDT 
<rdar://problem/34692995>