Bug 177441 - Building release with -DLOG_DISABLED=0 fails
Summary: Building release with -DLOG_DISABLED=0 fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-25 11:03 PDT by Carlos Alberto Lopez Perez
Modified: 2017-09-27 12:18 PDT (History)
12 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2017-09-25 11:07 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-09-25 11:03:12 PDT 
Building WebKitGTK+ release with CXXFLAGS='-DLOG_DISABLED=0' to enable logs results in this build failure:


FAILED: Source/WebCore/CMakeFiles/WebCore.dir/Modules/indexeddb/IDBObjectStore.cpp.o 
/usr/lib/ccache/clang++   -DBUILDING_GTK__=1 [....] Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:427:116: error: use of undeclared identifier 'loggingString'
    LOG(IndexedDB, "IDBObjectStore::createIndex %s (keyPath: %s, unique: %i, multiEntry: %i)", name.utf8().data(), loggingString(keyPath).utf8().data(), parameters.unique, parameters.multiEntry);
                                                                                                                   ^
1 error generated.
Comment 1 Carlos Alberto Lopez Perez 2017-09-25 11:07:44 PDT 
Created attachment 321703 [details]
Patch
Comment 2 Michael Catanzaro 2017-09-25 12:39:59 PDT 
Comment on attachment 321703 [details]
Patch

Not sure if I'm more surprised that you tried to do this, or that it's the only problem.
Comment 3 WebKit Commit Bot 2017-09-25 13:06:15 PDT 
Comment on attachment 321703 [details]
Patch

Clearing flags on attachment: 321703

Committed r222459: <http://trac.webkit.org/changeset/222459>
Comment 4 WebKit Commit Bot 2017-09-25 13:06:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:18:05 PDT 
<rdar://problem/34692985>