Bug 177431 - Update compressedTexImage3D to match the signature in the specification.
Summary: Update compressedTexImage3D to match the signature in the specification.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ms2ger (he/him; ⌚ UTC+1/+2)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-25 06:56 PDT by Ms2ger (he/him; ⌚ UTC+1/+2)
Modified: 2017-09-27 12:17 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.02 KB, patch)
2017-09-25 07:03 PDT, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags Details | Formatted Diff | Diff
Patch (4.92 KB, patch)
2017-09-26 00:44 PDT, Ms2ger (he/him; ⌚ UTC+1/+2) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ms2ger (he/him; ⌚ UTC+1/+2) 2017-09-25 06:56:00 PDT 
.
Comment 1 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-09-25 07:03:30 PDT 
Created attachment 321680 [details]
Patch
Comment 2 Sam Weinig 2017-09-25 16:58:26 PDT 
Comment on attachment 321680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321680&action=review

> Source/WebCore/html/canvas/WebGL2RenderingContext.h:76
> +    void compressedTexImage3D(GC3Denum target, GC3Dint level, GC3Denum internalformat, GC3Dsizei width, GC3Dsizei height, GC3Dsizei depth, GC3Dint border, RefPtr<ArrayBufferView>&& srcData, GC3Duint srcOffset, GC3Duint srcLengthOverride);

The ArrayBuffer can probably be a ArrayBufferView&, since the IDL parameter is not nullable.
Comment 3 Ms2ger (he/him; ⌚ UTC+1/+2) 2017-09-26 00:44:26 PDT 
Created attachment 321806 [details]
Patch
Comment 4 WebKit Commit Bot 2017-09-26 01:13:42 PDT 
Comment on attachment 321806 [details]
Patch

Clearing flags on attachment: 321806

Committed r222496: <http://trac.webkit.org/changeset/222496>
Comment 5 WebKit Commit Bot 2017-09-26 01:13:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:17:12 PDT 
<rdar://problem/34692943>