RESOLVED FIXED 177429
Add WeakPtr support to RenderObject. 
https://bugs.webkit.org/show_bug.cgi?id=177429
Summary Add WeakPtr support to RenderObject.
zalan
Reported 2017-09-25 06:14:56 PDT
and remove it from the subclasses.
Attachments
Patch (11.30 KB, patch)
2017-09-25 06:57 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (11.10 KB, patch)
2017-09-29 09:16 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2017-09-25 06:15:36 PDT
This is related to bug 177389
Radar WebKit Bug Importer
Comment 2 2017-09-25 06:16:57 PDT
<rdar://problem/34625212>
zalan
Comment 3 2017-09-25 06:57:52 PDT
Created attachment 321679 [details] Patch
zalan
Comment 4 2017-09-29 09:16:42 PDT
Created attachment 322188 [details] Patch
WebKit Commit Bot
Comment 5 2017-09-29 10:51:02 PDT
Comment on attachment 322188 [details] Patch Clearing flags on attachment: 322188 Committed r222653: <http://trac.webkit.org/changeset/222653>
WebKit Commit Bot
Comment 6 2017-09-29 10:51:05 PDT
All reviewed patches have been landed. Closing bug.
Antti Koivisto
Comment 7 2017-09-29 11:22:04 PDT
Comment on attachment 322188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322188&action=review > Source/WebCore/rendering/RenderMultiColumnFlow.cpp:441 > + m_spannerMap.add(placeholder.spanner(), placeholder.createWeakPtr<RenderMultiColumnSpannerPlaceholder>()); This is bit awkward. Could we have a standalone template function so we could just do makeWeakPtr(placeholder) and get correctly typed WeakPtr automatically?
Geoffrey Garen
Comment 8 2017-09-29 11:32:21 PDT
> > Source/WebCore/rendering/RenderMultiColumnFlow.cpp:441 > > + m_spannerMap.add(placeholder.spanner(), placeholder.createWeakPtr<RenderMultiColumnSpannerPlaceholder>()); > > This is bit awkward. Could we have a standalone template function so we > could just do > > makeWeakPtr(placeholder) > > and get correctly typed WeakPtr automatically? Totally! Maybe we should also change the interface so that WeakPtrFactory vends WeakReference<T>& instead of WeakPtr<T> and WeakPtr<T> automatically constructs itself, just like RefPtr, using that WeakReference<T>&.
Note You need to log in before you can comment on or make changes to this bug.