Bug 177427 - Support building JavaScriptCore with the Bionic C library
Summary: Support building JavaScriptCore with the Bionic C library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-25 01:40 PDT by Zan Dobersek
Modified: 2017-09-27 12:17 PDT (History)
13 users (show)

See Also:

Attachments
Patch (4.26 KB, patch)
2017-09-25 04:23 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-09-25 01:40:51 PDT 
The Bionic C library doesn't define __GLIBC__ macro like some other non-GNU C libraries, so the __BIONIC__ macro has to be handled in parallel.
Comment 1 Zan Dobersek 2017-09-25 04:23:57 PDT 
Created attachment 321677 [details]
Patch
Comment 2 Michael Catanzaro 2017-09-25 07:20:16 PDT 
Comment on attachment 321677 [details]
Patch

If this is all that's needed to get JSC working properly, then OK. It's clearly no maintenance burden.
Comment 3 Zan Dobersek 2017-09-26 00:07:48 PDT 
Comment on attachment 321677 [details]
Patch

Clearing flags on attachment: 321677

Committed r222495: <http://trac.webkit.org/changeset/222495>
Comment 4 Zan Dobersek 2017-09-26 00:07:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:17:05 PDT 
<rdar://problem/34692940>