Bug 177421 - JSC build should use unified sources for derived sources
Summary: JSC build should use unified sources for derived sources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-24 18:48 PDT by Keith Miller
Modified: 2017-09-27 12:19 PDT (History)
6 users (show)

See Also:

Attachments
Patch (65.58 KB, patch)
2017-09-24 18:55 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Try without JSCBuiltins (67.51 KB, patch)
2017-09-26 07:15 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (68.47 KB, patch)
2017-09-26 08:16 PDT, Keith Miller 		jfbastien: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-09-24 18:48:34 PDT 
JSC build should use unified sources for derived sources
Comment 1 Keith Miller 2017-09-24 18:55:28 PDT 
Created attachment 321662 [details]
Patch
Comment 2 Keith Miller 2017-09-24 18:57:50 PDT 
I chose to not have any special marking to describe derived sources in our Sources.txt files since it seemed unnecessary. I considered prefixing them with a * but I figured that would just be confusing. Having a general rule about putting a comment stating a source is derived would be sufficient.
Comment 3 Keith Miller 2017-09-25 09:35:10 PDT 
Comment on attachment 321662 [details]
Patch

Looks like windows build is broken.
Comment 4 Keith Miller 2017-09-26 07:15:37 PDT 
Created attachment 321813 [details]
Try without JSCBuiltins
Comment 5 Keith Miller 2017-09-26 08:16:33 PDT 
Created attachment 321816 [details]
Patch
Comment 6 JF Bastien 2017-09-26 08:23:19 PDT 
Comment on attachment 321816 [details]
Patch

r=me
Comment 7 Keith Miller 2017-09-26 08:34:24 PDT 
Committed r222499: <http://trac.webkit.org/changeset/222499>
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:19:02 PDT 
<rdar://problem/34693016>