NEW 177413
Remove use of CallWith=ActiveWindow&FirstWindow from attribute setters 
https://bugs.webkit.org/show_bug.cgi?id=177413
Summary Remove use of CallWith=ActiveWindow&FirstWindow from attribute setters
youenn fablet
Reported 2017-09-23 21:58:15 PDT
It is used in one class and passing ExecState is as simple.
Attachments
Patch (3.70 KB, patch)
2017-09-23 21:59 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-09-23 21:59:01 PDT
Created attachment 321644 [details] Patch
Sam Weinig
Comment 2 2017-09-24 20:46:46 PDT
I don't think this is an improvement. I'd rather keep the explicit types. What's the motivation for this?
youenn fablet
Comment 3 2017-09-28 09:48:10 PDT
Here are some reasons: - CallWith=ActiveWindow&FirstWindow is not used much for attributes. Refactoring is very small. - The API does not seem very clear to me with two DOMWindow arguments compared to passing an ExecState. - In the future, the setter signatures could be used to decide whether passing an ExecState or not instead of a keyword in the iDL.
Note You need to log in before you can comment on or make changes to this bug.