Bug 177407 - test262: $.agent became $262.agent in test262 update
Summary: test262: $.agent became $262.agent in test262 update
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-23 02:01 PDT by Joseph Pecoraro
Modified: 2017-09-27 12:18 PDT (History)
10 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (194.70 KB, patch)
2017-09-23 02:17 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (194.80 KB, patch)
2017-09-23 02:58 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-09-23 02:01:13 PDT 
test262: $.agent became $262.agent in test262 update

Oops. For now I'll expose both `$` and `$262` in jsc, and then transition away from $ (used in a few of our tests).
Comment 1 Joseph Pecoraro 2017-09-23 02:17:06 PDT 
Created attachment 321624 [details]
[PATCH] Proposed Fix

Not cq yet since I am still running tests with the new expectations file and I might have missed one or two.
Comment 2 Joseph Pecoraro 2017-09-23 02:58:05 PDT 
Created attachment 321626 [details]
[PATCH] Proposed Fix
Comment 3 Yusuke Suzuki 2017-09-23 03:33:43 PDT 
Comment on attachment 321626 [details]
[PATCH] Proposed Fix

r=me, nice
Comment 4 WebKit Commit Bot 2017-09-23 04:01:06 PDT 
Comment on attachment 321626 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 321626

Committed r222424: <http://trac.webkit.org/changeset/222424>
Comment 5 WebKit Commit Bot 2017-09-23 04:01:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:18:51 PDT 
<rdar://problem/34693007>