Bug 177403 – Add helper functions to write better selection tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Megan Gardner]

Add helper function to write better selection tests

[Megan Gardner]

Created attachment 321613 [details]
Patch

[Wenson Hsieh]

Comment on attachment 321613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321613&action=review

> LayoutTests/ChangeLog:9
> +        that can assist it the calculation of word location, and in helping debug

"...that can make it easier to calculate word location, and help debug..."?

> LayoutTests/fast/events/touch/ios/resources/text-calculations.js:24
> +function measureLineWidth(string, fontFamily = "monospace", fontSize = "18px")

Hm...did you try using measureText(~).width and find that it wasn't accurate enough for your purpose? I'm a bit curious how/why we would use measureFontHeight and measureLineWidth to help debug layout tests. If it's to try and track down the location of a run of text that we want to select, would it suffice to wrap that text around a span with id="foo", and just use foo.getBoundingClientRect()?

> LayoutTests/fast/events/touch/ios/resources/ui-debugging.js:1
> +// To double check location of touches or other x,y coordinants

s/coordinants/coordinates/

> LayoutTests/fast/events/touch/ios/resources/ui-debugging.js:2
> +// WARNING: If you leave this on, it is selectable, as it is an HTML element.

Perhaps you give this debug element the `pointer-events: none` style?

> LayoutTests/fast/events/touch/ios/resources/ui-debugging.js:3
> +// There is no real way around this. Just be aware when testing, it's presense will likely mess up your test.

s/presense/presence/

> LayoutTests/fast/events/touch/ios/resources/ui-debugging.js:29
> +// To double check location of word boxes or other x,y coordinants

Ditto on typos/pointer-events: none.

[Megan Gardner]

Created attachment 321783 [details]
Patch

[Megan Gardner]

Turns out using <span> tags gives me the results I want in being able to determine where selection rects should be, so the measurements functions aren't needed. And setting the pointer-events style makes them invisible to touch, so that helps make them more useful. These are basically debug tools, but having them all written up makes it easier to use them later.

[Tim Horton]

Comment on attachment 321783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321783&action=review

> LayoutTests/fast/events/touch/ios/resources/ui-debugging.js:18
> +    dot.style.left = (x-dotSize/2)+"px";

spaces around math operators!

> LayoutTests/fast/events/touch/ios/resources/ui-debugging.js:46
> +    rect.style.top = y+"px";

ditto, etc.

[Megan Gardner]

https://trac.webkit.org/r222517

[Radar WebKit Bug Importer]

<rdar://problem/34693125>

[Frédéric Wang (:fredw)]

@Megan: Was ui-debugging.js actually used at the end?

[Wenson Hsieh]

(In reply to Frédéric Wang (:fredw) from comment #8)
> @Megan: Was ui-debugging.js actually used at the end?

I think the intention behind ui-debugging.js is to make it a bit easier to write UI-script-driven tests, especially on iOS.

One could use some of the functionality in ui-debugging.js to make it easier to diagnose and triage test failures by adding visual indication of where synthetic events are being dispatched, but would ultimately remove code that inserts these debug elements into the DOM before check-in.