Bug 177402 - Web Inspector: Reduce work during resizing
Summary: Web Inspector: Reduce work during resizing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-22 18:20 PDT by Joseph Pecoraro
Modified: 2017-09-27 12:17 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.13 KB, patch)
2017-09-22 18:21 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (1.25 KB, patch)
2017-09-22 18:29 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-09-22 18:20:01 PDT 
Reduce work during resizing

We don't need to refresh CodeMirror in the ConsolePrompt when it is empty. Nothing changes in the prompt but we are spending a bunch of time there under refresh. CodeMirror has its own resize detection as well.
Comment 1 Joseph Pecoraro 2017-09-22 18:21:10 PDT 
Created attachment 321606 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2017-09-22 18:24:33 PDT 
Comment on attachment 321606 [details]
[PATCH] Proposed Fix

Actually I wonder if we can just remove this.
Comment 3 Joseph Pecoraro 2017-09-22 18:29:45 PDT 
Created attachment 321609 [details]
[PATCH] Proposed Fix

The only case where the refresh() mattered was switching tabs (causing sidebars to go away and the console size to change size).

For an empty console we shouldn't need to refresh anything.
Comment 4 Matt Baker 2017-09-24 11:27:13 PDT 
Comment on attachment 321609 [details]
[PATCH] Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2017-09-24 11:55:07 PDT 
Comment on attachment 321609 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 321609

Committed r222436: <http://trac.webkit.org/changeset/222436>
Comment 6 WebKit Commit Bot 2017-09-24 11:55:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:17:21 PDT 
<rdar://problem/34692954>