Bug 177387 - Web Inspector: Remove SidebarPanel show/hide and added/removed
Summary: Web Inspector: Remove SidebarPanel show/hide and added/removed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-22 15:06 PDT by Matt Baker
Modified: 2017-09-27 12:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.65 KB, patch)
2017-09-22 15:08 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
Patch (5.04 KB, patch)
2017-09-22 16:02 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-09-22 15:06:40 PDT 
These are not being used, and just contribute to view lifecycle noise (show, hide, shown, hidden, closed).
Comment 1 Matt Baker 2017-09-22 15:08:12 PDT 
Created attachment 321594 [details]
Patch
Comment 2 Matt Baker 2017-09-22 16:01:23 PDT 
SidebarPanel.prototype.show/hide just set the selected panel and collapsed/uncollapsed the sidebar. `hide` was unused, and `show` was only used in two special cases.

These methods provided no functionality beyond what can easily be accomplished via the Sidebar, and were confusing due to their similarity to shown/hidden.
Comment 3 Matt Baker 2017-09-22 16:02:57 PDT 
Created attachment 321599 [details]
Patch
Comment 4 Devin Rousso 2017-09-22 16:52:33 PDT 
Comment on attachment 321599 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2017-09-22 17:55:27 PDT 
Comment on attachment 321599 [details]
Patch

Clearing flags on attachment: 321599

Committed r222420: <http://trac.webkit.org/changeset/222420>
Comment 6 WebKit Commit Bot 2017-09-22 17:55:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-09-27 12:21:01 PDT 
<rdar://problem/34693102>