Bug 177379 - Web Inspector: NavigationBar should coalesce consecutive dividers when items are hidden
Summary: Web Inspector: NavigationBar should coalesce consecutive dividers when items ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-22 13:17 PDT by Matt Baker
Modified: 2017-09-27 12:18 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.61 KB, patch)
2017-09-22 13:19 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-09-22 13:17:47 PDT 
Summary:
NavigationBar should coalesce consecutive dividers when items are hidden. Currently this is only done when items are forced hidden when collapsing the bar to fit the available space. We should always coalesce dividers during a layout, since hiding items (NavigationItem.prototype.hidden) can also cause dividers to pile up.
Comment 1 Matt Baker 2017-09-22 13:19:02 PDT 
Created attachment 321587 [details]
Patch
Comment 2 Joseph Pecoraro 2017-09-22 13:39:49 PDT 
Comment on attachment 321587 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2017-09-22 14:08:31 PDT 
Comment on attachment 321587 [details]
Patch

Clearing flags on attachment: 321587

Committed r222405: <http://trac.webkit.org/changeset/222405>
Comment 4 WebKit Commit Bot 2017-09-22 14:08:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:18:55 PDT 
<rdar://problem/34693012>