Bug 177376 - bisect-builds:add a README to the archive
Summary: bisect-builds:add a README to the archive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-22 12:19 PDT by Lucas Forschler
Modified: 2017-09-27 10:12 PDT (History)
5 users (show)

See Also:


Attachments
v1 patch for review (2.76 KB, patch)
2017-09-22 12:21 PDT, Lucas Forschler
lforschler: commit-queue-
Details | Formatted Diff | Diff
v2 patch, moving support files to a new WebKitArchiveSupport folder (10.03 KB, patch)
2017-09-22 13:09 PDT, Lucas Forschler
ap: review+
lforschler: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2017-09-22 12:19:14 PDT
WebKit archives are unsigned, and thus they cannot be launched with a simple double click.
We need to add a README to the WebKit archives which explain how to launch them using Control-click.
Comment 1 Radar WebKit Bug Importer 2017-09-22 12:19:39 PDT
<rdar://problem/34600293>
Comment 2 Lucas Forschler 2017-09-22 12:21:40 PDT
Created attachment 321577 [details]
v1 patch for review
Comment 3 Alexey Proskuryakov 2017-09-22 12:30:54 PDT
Comment on attachment 321577 [details]
v1 patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=321577&action=review

> Tools/ChangeLog:8
> +        * BuildSlaveSupport/README: Added.

This is not a good name for a file at the root of BuildSlaveSupport. It's not a readme for BuildSlaveSupport.
Comment 4 Lucas Forschler 2017-09-22 13:09:41 PDT
Created attachment 321585 [details]
v2 patch, moving support files to a new WebKitArchiveSupport folder
Comment 5 Lucas Forschler 2017-09-27 10:12:13 PDT
Committed revision 222558.