Bug 177371 – Add env() as an alias of constant()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Add env() as an alias of constant()

[Tim Horton]

Created attachment 321570 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/34599168>

[Tim Horton]

Created attachment 321571 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 321571 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321571&action=review

Inspector parts look good to me.

> Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js:71
> +    else if (functionName === "constant" || functionName == "env")

Please add this as well, so that `env()` gets syntax highlighted like `var()` / `constant()` do.

diff --git a/Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js b/Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js
index 56860424e21..434f841c6a1 100644
--- a/Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js
+++ b/Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js
@@ -97,7 +97,7 @@ WI.CSSCompletions = class CSSCompletions
                 return;
 
             var propertyNamesForCodeMirror = {};
-            var valueKeywordsForCodeMirror = {"inherit": true, "initial": true, "unset": true, "revert": true, "var": true, "constant": true};
+            var valueKeywordsForCodeMirror = {"inherit": true, "initial": true, "unset": true, "revert": true, "var": true, "constant": true, "env": true};
             var colorKeywordsForCodeMirror = {};
 
             function nameForCodeMirror(name)

[Tim Horton]

Created attachment 321578 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 321578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321578&action=review

> LayoutTests/TestExpectations:38
> +fast/css/variables/env/ios [ Skip ]

Hmm this is pretty sad. Maybe we should have some testing-specific env values?

[Tim Horton]

(In reply to Simon Fraser (smfr) from comment #6)
> Comment on attachment 321578 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=321578&action=review
> 
> > LayoutTests/TestExpectations:38
> > +fast/css/variables/env/ios [ Skip ]
> 
> Hmm this is pretty sad. Maybe we should have some testing-specific env
> values?

This only skips 1/4 tests. But yes, we should have further coverage with more types and non-zero values.

[WebKit Commit Bot]

Comment on attachment 321578 [details]
Patch

Clearing flags on attachment: 321578

Committed r222402: <http://trac.webkit.org/changeset/222402>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.