Bug 177369 - Align Media Source Extension IDL with spec
Summary: Align Media Source Extension IDL with spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nael Ouedraogo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-22 10:46 PDT by Nael Ouedraogo
Modified: 2017-09-27 12:17 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.25 KB, patch)
2017-09-22 10:51 PDT, Nael Ouedraogo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nael Ouedraogo 2017-09-22 10:46:32 PDT
Align Media Source Extension IDL with spec.
Comment 1 Nael Ouedraogo 2017-09-22 10:51:05 PDT
Created attachment 321565 [details]
Patch
Comment 2 Sam Weinig 2017-09-22 13:29:31 PDT
Comment on attachment 321565 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321565&action=review

> Source/WebCore/ChangeLog:9
> +        Align IDL as per specification:
> +         - https://www.w3.org/TR/media-source/

Can you add tests for these (probably only the SourceBuffer.idl one is directly testable actually).
Comment 3 Nael Ouedraogo 2017-09-25 04:59:30 PDT
Thanks for the review. 

> Can you add tests for these (probably only the SourceBuffer.idl one is
> directly testable actually).

There is a test (mediasource-remove.html) in WPT that already checks that an exception is thrown when calling remove method with non-finite start values.
Comment 4 WebKit Commit Bot 2017-09-25 05:27:40 PDT
Comment on attachment 321565 [details]
Patch

Clearing flags on attachment: 321565

Committed r222443: <http://trac.webkit.org/changeset/222443>
Comment 5 WebKit Commit Bot 2017-09-25 05:27:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:17:58 PDT
<rdar://problem/34692980>