RESOLVED FIXED 177361
Add asserts against layout time render tree mutations 
https://bugs.webkit.org/show_bug.cgi?id=177361
Summary Add asserts against layout time render tree mutations
Antti Koivisto
Reported 2017-09-22 06:14:01 PDT
Make sure this doesn't happen anymore.
Attachments
patch (1.74 KB, patch)
2017-09-22 06:17 PDT, Antti Koivisto 		zalan: review+
DetailsFormatted DiffDiff
patch (1.84 KB, patch)
2017-09-22 07:12 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-09-22 06:17:26 PDT
Created attachment 321538 [details] patch
Antti Koivisto
Comment 2 2017-09-22 07:12:35 PDT
Created attachment 321542 [details] patch
Radar WebKit Bug Importer
Comment 3 2017-09-22 10:24:39 PDT
<rdar://problem/34597308>
WebKit Commit Bot
Comment 4 2017-09-22 10:45:13 PDT
Comment on attachment 321542 [details] patch Clearing flags on attachment: 321542 Committed r222393: <http://trac.webkit.org/changeset/222393>
WebKit Commit Bot
Comment 5 2017-09-22 10:45:14 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 6 2017-09-23 17:33:37 PDT
Comment on attachment 321542 [details] patch How did you chose RELEASE_ASSERT over ASSERT?
Antti Koivisto
Comment 7 2017-09-24 00:00:57 PDT
These are pretty dangerous and the check is cheap. I'm also interested in finding if our test coverage is missing anything.
Antti Koivisto
Comment 8 2017-09-24 00:02:09 PDT
I don't know if we have some sort of policy on when to use RELEASE_ASSERT.
Darin Adler
Comment 9 2017-09-24 16:26:46 PDT
(In reply to Antti Koivisto from comment #8) > I don't know if we have some sort of policy on when to use RELEASE_ASSERT. I think we should, although I don’t know what it should be. Not a "policy" necessarily, but some conceptual framework for when to use one vs. the other. I will help us implement it consistently once we decide.
Note You need to log in before you can comment on or make changes to this bug.