Bug 177361 - Add asserts against layout time render tree mutations
Summary: Add asserts against layout time render tree mutations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-22 06:14 PDT by Antti Koivisto
Modified: 2017-09-24 16:26 PDT (History)
6 users (show)

See Also:

Attachments
patch (1.74 KB, patch)
2017-09-22 06:17 PDT, Antti Koivisto 		zalan: review+
Details | Formatted Diff | Diff
patch (1.84 KB, patch)
2017-09-22 07:12 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-09-22 06:14:01 PDT 
Make sure this doesn't happen anymore.
Comment 1 Antti Koivisto 2017-09-22 06:17:26 PDT 
Created attachment 321538 [details]
patch
Comment 2 Antti Koivisto 2017-09-22 07:12:35 PDT 
Created attachment 321542 [details]
patch
Comment 3 Radar WebKit Bug Importer 2017-09-22 10:24:39 PDT 
<rdar://problem/34597308>
Comment 4 WebKit Commit Bot 2017-09-22 10:45:13 PDT 
Comment on attachment 321542 [details]
patch

Clearing flags on attachment: 321542

Committed r222393: <http://trac.webkit.org/changeset/222393>
Comment 5 WebKit Commit Bot 2017-09-22 10:45:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2017-09-23 17:33:37 PDT 
Comment on attachment 321542 [details]
patch

How did you chose RELEASE_ASSERT over ASSERT?
Comment 7 Antti Koivisto 2017-09-24 00:00:57 PDT 
These are pretty dangerous and the check is cheap. I'm also interested in finding if our test coverage is missing anything.
Comment 8 Antti Koivisto 2017-09-24 00:02:09 PDT 
I don't know if we have some sort of policy on when to use RELEASE_ASSERT.
Comment 9 Darin Adler 2017-09-24 16:26:46 PDT 
(In reply to Antti Koivisto from comment #8)
> I don't know if we have some sort of policy on when to use RELEASE_ASSERT.

I think we should, although I don’t know what it should be. Not a "policy" necessarily, but some conceptual framework for when to use one vs. the other. I will help us implement it consistently once we decide.