LayoutTest webrtc/video-mute.html is very often failing
Created attachment 321492 [details] Patch
Comment on attachment 321492 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321492&action=review > LayoutTests/webrtc/video-mute.html:-70 > - internals.observeMediaStreamTrack(remoteTrack); If observeMediaStreamTrack doesn’t work reliably, should we also be removing it?
Thanks for the review. (In reply to Darin Adler from comment #2) > Comment on attachment 321492 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=321492&action=review > > > LayoutTests/webrtc/video-mute.html:-70 > > - internals.observeMediaStreamTrack(remoteTrack); > > If observeMediaStreamTrack doesn’t work reliably, should we also be removing > it? observeMediaStreamTrack works but it seems that trackVideoSampleCount is not always working properly for this particular test. It is used in LayoutTests/fast/mediastream/captureStream/canvas2d-heavy-drawing.html and seems to work fine there (we cannot replace it there). Since we just want to make sure that one frame is sent at the webrtc level, getStats is more appropriate anyway.
Comment on attachment 321492 [details] Patch Clearing flags on attachment: 321492 Committed r222445: <http://trac.webkit.org/changeset/222445>
All reviewed patches have been landed. Closing bug.
<rdar://problem/34693164>