Bug 177331 – LayoutTest webrtc/video-mute.html is very often failing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

LayoutTest webrtc/video-mute.html is very often failing

[youenn fablet]

Created attachment 321492 [details]
Patch

[Darin Adler]

Comment on attachment 321492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321492&action=review

> LayoutTests/webrtc/video-mute.html:-70
> -    internals.observeMediaStreamTrack(remoteTrack);

If observeMediaStreamTrack doesn’t work reliably, should we also be removing it?

[youenn fablet]

Thanks for the review.

(In reply to Darin Adler from comment #2)
> Comment on attachment 321492 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=321492&action=review
> 
> > LayoutTests/webrtc/video-mute.html:-70
> > -    internals.observeMediaStreamTrack(remoteTrack);
> 
> If observeMediaStreamTrack doesn’t work reliably, should we also be removing
> it?

observeMediaStreamTrack works but it seems that trackVideoSampleCount is not always working properly for this particular test.
It is used in LayoutTests/fast/mediastream/captureStream/canvas2d-heavy-drawing.html and seems to work fine there (we cannot replace it there).

Since we just want to make sure that one frame is sent at the webrtc level, getStats is more appropriate anyway.

[WebKit Commit Bot]

Comment on attachment 321492 [details]
Patch

Clearing flags on attachment: 321492

Committed r222445: <http://trac.webkit.org/changeset/222445>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34693164>