Bug 177321 - Regression(r222308): new API tests are failing for !NETWORK_SESSION
Summary: Regression(r222308): new API tests are failing for !NETWORK_SESSION
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 176628
  Show dependency treegraph
 
Reported: 2017-09-21 12:59 PDT by Chris Dumez
Modified: 2017-09-27 12:19 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.00 KB, patch)
2017-09-21 13:02 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (3.82 KB, patch)
2017-09-21 13:21 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-09-21 12:59:21 PDT
new API tests are failing for !NETWORK_SESSION.
Comment 1 Chris Dumez 2017-09-21 13:02:33 PDT
Created attachment 321468 [details]
Patch
Comment 2 Chris Dumez 2017-09-21 13:03:15 PDT
Failures look like so:
FAIL _WKDownload.RedirectedLoadConvertedToDownload

/Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:472
Value of: [url.absoluteString UTF8String]
  Actual: "http://pass/"
Expected: "http://redirect/?pass"


/Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:481
Value of: redirectChain.count
  Actual: 4
Expected: 3U
Which is: 3


/Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:545
Value of: redirectCount
  Actual: 1
Expected: 0U
Which is: 0

FAIL _WKDownload.RedirectedSubframeLoadConvertedToDownload

/Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:472
Value of: [url.absoluteString UTF8String]
  Actual: "http://pass/"
Expected: "http://redirect/?pass"


/Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:481
Value of: redirectChain.count
  Actual: 4
Expected: 3U
Which is: 3


/Volumes/Data/slave/elcapitan-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:567
Value of: redirectCount
  Actual: 1
Expected: 0U
Which is: 0
Comment 3 Chris Dumez 2017-09-21 13:21:26 PDT
Created attachment 321470 [details]
Patch
Comment 4 WebKit Commit Bot 2017-09-21 15:08:43 PDT
Comment on attachment 321470 [details]
Patch

Clearing flags on attachment: 321470

Committed r222355: <http://trac.webkit.org/changeset/222355>
Comment 5 WebKit Commit Bot 2017-09-21 15:08:44 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:19:13 PDT
<rdar://problem/34693029>